Skip to content

Don't pass empty strings to go-imap - #45

Open
ptrcnull wants to merge 3 commits into
foxcpp:masterfrom
ptrcnull:fix-empty-flag
Open

Don't pass empty strings to go-imap#45
ptrcnull wants to merge 3 commits into
foxcpp:masterfrom
ptrcnull:fix-empty-flag

Conversation

@ptrcnull

@ptrcnull ptrcnull commented Sep 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

closes #44
closes #46

@ptrcnull
ptrcnull marked this pull request as draft September 11, 2023 01:19
@ptrcnull

ptrcnull commented Sep 11, 2023

Copy link
Copy Markdown
Contributor Author

actually, it still doesn't fix the whole issue:

* 11295 FETCH (UID 31113 FLAGS ( \Seen nonjunk) BODYSTRUCTURE ("text" "html" ("charset" "UTF-8") NIL NIL "quoted-printable" 35910 779 NIL NIL NIL NIL) ENVELOPE ("Sat, 09 Sep 2023 22:12:10 +0000" "[RESOLVED]  (Disk usage)" (("Grafana" NIL "grafana" "ptrc.gay")) (("Grafana" NIL "grafana" "ptrc.gay")) (("Grafana" NIL "grafana" "ptrc.gay")) ((NIL NIL "alerts" "ptrcnull.me")) NIL NIL NIL "<some-made-up-uuid@mail.torastian.com>"))

you might notice the FLAGS parenthesized list still having an empty element at the beginning

@ptrcnull
ptrcnull force-pushed the fix-empty-flag branch 2 times, most recently from eeda037 to 7e70912 Compare September 11, 2023 02:40
@ptrcnull
ptrcnull marked this pull request as ready for review September 11, 2023 02:41
@ptrcnull ptrcnull changed the title Don't pass empty string to go-imap MailboxStatus flags Don't pass empty strings to go-imap Sep 11, 2023
@ptrcnull
ptrcnull marked this pull request as draft September 11, 2023 11:19
@ptrcnull

ptrcnull commented Sep 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

haha, nevermind, this PR somehow makes thunderbird just outright.. not pull messages from the server
it doesn't error out or anything

EDIT: it's just that last commit, apparently...

@ptrcnull

ptrcnull commented Sep 11, 2023

Copy link
Copy Markdown
Contributor Author

fixed it

@ptrcnull
ptrcnull marked this pull request as ready for review September 11, 2023 11:30
@ptrcnull

ptrcnull commented Sep 11, 2023

Copy link
Copy Markdown
Contributor Author

tested with:

  • Thunderbird 115.2.0
  • aerc 0.15.2
  • K-9 Mail 6.602
  • alps 652ea9c7 ( go-imap v2 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Messages without a Content-Transfer-Encoding header pass an empty encoding to go-imap Flags/PermanentFlags somehow contains an empty string

1 participant

@ptrcnull