Repository navigation
fix: render Kitty graphics reliably inside tmux (issue #84) - #124
Closed
yaroslavsavateykin wants to merge 1 commit into
Closed
yaroslavsavateykin wants to merge 1 commit into
yaroslavsavateykin wants to merge 1 commit into
Conversation
Author
|
Follow-up in 3d4554f: repeated recompilation can unlink/recreate the PDF and stop the inode-based file watcher. The tmux ticker now also polls inode/size/mtime by path and reloads after stable metadata, retaining the previous page during temporary absence. Watcher errors no longer terminate the tmux viewer, and status-path realpath tolerates FileNotFound. Verified three consecutive unlink/recreate cycles (600ms missing output each), with red/blue/green page content visibly updated on every cycle. ReleaseSmall build and 3/3 graphics tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #84 for a single tmux layer with a terminal supporting Kitty Unicode placeholders. This is a real graphics transport/placement implementation, not a bypass of
NoGraphicsCapability.Related: #107 and rockorager/libvaxis#260. I saw the existing experimental branch and the reports of blank Kitty output / residual images; this implementation uses tmux-owned placeholder cells rather than terminal-owned direct placements.
Graphics path
OKresponse to a valid 1x1 RGB capability query through the same tmux DCS route used by image data.Technical reference: gominimal/kittyview, particularly its DCS transport, MuxSafe image-ID encoding, Unicode placeholder table and client repaint strategy.
libvaxis dependency / review point
This PR vendors the same pinned libvaxis commit previously referenced by
build.zig.zon, with its MIT license. The large diff is mostly unchanged dependency source, not newly written backend code.deps/vaxis/UPSTREAM.mdlists the five files changed: valid query, ID/status response parsing, response event, atomic ACK slot and input-loop forwarding.I am happy to replace vendoring with a URL/hash dependency once equivalent response hooks are available upstream. This is an explicit integration decision for maintainers, not a proposed permanent fork of the library.
Validation
zig build --release=small— successful.zig build test— 3 tests passed (DCS escaping, complete MuxSafe ID-space uniqueness, positive/negative protocol reply parsing).zig fmt --checkon changed Zig files andgit diff --check— passed.allow-passthroughproduces a capability failure instead of pretending graphics are available.Requirements and current limits
set -g allow-passthrough onDetails are in
docs/tmux.md. Local screenshots/build artifacts and installed binaries are deliberately excluded from this PR.