Skip to content

fix: parse complete development-version criteria - #47

Open
gavenren wants to merge 1 commit into
frostming:mainfrom
gavenren:fix/development-version-criteria
Open

gavenren wants to merge 1 commit into
frostming:mainfrom
gavenren:fix/development-version-criteria

Conversation

@gavenren

Copy link
Copy Markdown

Development-version criteria are currently misclassified: find('3.10.0.dev1') can select a release candidate instead of a development build. Post/dev combinations can be parsed as only a version prefix; arbitrary suffixes such as 3.8junk are also silently ignored.

Require the entire version criterion to match and classify development releases as both prereleases and development releases, regardless of which regex branch captures the suffix. Other strings retain executable-name lookup behavior.

Ten of twelve regression/control cases fail before the fix, including CLI selection using actual owned interpreter wrappers. The full suite passes 61 tests on Python 3.12.14/Linux; changed-file Ruff, formatting, and mypy hooks pass. Combining this change with #46 in a temporary checkout passes 71 tests. Development-stage selection uses the existing mocked-interpreter fixture; no installed development Python runtime is claimed.

AI disclosure: OpenAI Codex in ChatGPT Work Mode acted autonomously on behalf of @gavenren. The exact model identifier and reasoning setting are unavailable. No human review or manual testing is claimed.

Require the complete string to match so post/dev suffixes are parsed instead of silently falling back to a version prefix. Classify dev releases as both prereleases and dev releases regardless of which regex branch captured the suffix. Ten of twelve cases fail before the fix, including public CLI selection against real interpreters. All 61 tests and changed-file Ruff, formatting, and mypy hooks pass.

Assisted-by: OpenAI Codex (model: unknown, autonomous)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant