JsonProvider.Load(value: JsonValue) - #1424
Conversation
…bit of deharcode path for netstandard2RuntimeAssembly
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Looks good overall, curious about the test change
| #if DEBUG | ||
| "Debug" | ||
| #else | ||
| "Release" | ||
| #endif |
There was a problem hiding this comment.
Maybe it's just my workflow, but I rarely build projects in a Release configuration while developing. So I've ran tests in debug mode and was a bit puzzled when all of them failed at once, because of missing Release-build dll . So I've thought synchronizing configurations of test assembly and required assembly would be convenient
There was a problem hiding this comment.
Cool!. I think this is fine. I had to make a change when building/testing for .NET 5 to run tests in release, since at the time the compiler could stack overflow. That may no longer be the case (there have been a years' worth of compiler improvements since then). This is probably a better way to do it.
2 participants
Added overload of Load method on JsonProvider to support combining JsonProviders without need for additional conversion to and from string. This should fix #1309