Move to the .NET 11 RC 1 SDK - #3475
Merged
Merged
Conversation
Pin the SDK in global.json and add a mise.toml so mise installs it for this repository. The F# 13 compiler removed --strict-indentation, since strict indentation is now the only mode (dotnet/fsharp#20106). The three --test: parallel compilation flags were redundant since SDK 10.0.200, where graph-based checking, parallel optimization and parallel IlxGen became the default (dotnet/fsharp#18998); the compiler only kept the old spellings for the .NET 10 period. Only --realsig+ remains, as it is still off by default. Enable MSBuild's experimental multithreaded mode through a Directory.Build.rsp, with a .gitignore exception so the file is tracked. Drop dotnet-fsharplint from the tool manifest: nothing invokes it any more. Bump fsharp-analyzers and FSharp.Analyzers.SDK to 0.39.2.
fsharp-analyzers targets net10.0 and loads MSBuild from the SDK that global.json selects. The runtime host never rolls a release app onto a prerelease runtime while a release one is installed, so on a machine with runtime 10 the tool started on 10 and failed to load the SDK 11 assemblies. Set DOTNET_ROLL_FORWARD_TO_PRERELEASE on the Analyze stage of both analyzer pipelines, as the Docs stage already does for fsdocs. Base the devcontainer on the sdk:11.0.100-rc.1 image so it can satisfy global.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin the SDK in global.json and add a mise.toml so mise installs it for this repository.
The F# 13 compiler removed --strict-indentation, since strict indentation is now the only mode (dotnet/fsharp#20106). The three --test: parallel compilation flags were redundant since SDK 10.0.200, where graph-based checking, parallel optimization and parallel IlxGen became the default (dotnet/fsharp#18998); the compiler only kept the old spellings for the .NET 10 period. Only --realsig+ remains, as it is still off by default.
Enable MSBuild's experimental multithreaded mode through a Directory.Build.rsp, with a .gitignore exception so the file is tracked.
Drop dotnet-fsharplint from the tool manifest: nothing invokes it any more. Bump fsharp-analyzers and FSharp.Analyzers.SDK to 0.39.2.