Update FCS: exception keyword range - #3500
Merged
Merged
Conversation
…Repr', commit 349d6aaf1e4685a72e43b7f4a0708205e4104b4c Also takes in 'Remove trailing whitespace from src and vsintegration/src' (dotnet/fsharp#20393) and 'Enable runtime async via compiler intrinsics' (dotnet/fsharp#20235), neither of which needed a change here. The syntax tree now records the range of the `exception` keyword (dotnet/fsharp#20612). mkExceptionKeyword, which looked the keyword up in the source text, is gone, and so is the CodeComments field of CreationAide that only it used. The vendored FSharpEmbedResourceText task became a multithreaded MSBuild task in dotnet/fsharp#20506. Microsoft.Build.Framework and Microsoft.Build.Utilities.Core move to 18.10.1, which has IMultiThreadableTask and TaskEnvironment, and TaskEnvironmentPaths.fs is vendored alongside the task. FSharpEnvironment.fs stands in for the two members of the upstream module that file uses, because the real one needs generated sources this project does not have.
This was referenced Sep 25, 2026
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates FCS to dotnet/fsharp#20612