refactor: replace any with unknown, enable noImplicitAny - #76
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 96.19% 96.22% +0.02%
==========================================
Files 13 13
Lines 1499 1508 +9
Branches 135 136 +1
==========================================
+ Hits 1442 1451 +9
Misses 57 57
Continue to review full report at Codecov.
|
raveclassic
force-pushed
the
replace-any-with-unknown
branch
from
April 20, 2020 14:48
b3e3414 to
353dd83
Compare
Member
|
Thank you for showing interest and your contribution. Feel free to open an issue and ask about any of the implementation details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
First, thanks for this lib, I've spent quite a lot of time searching for something similar to hareactive and now looks like I have what I need, thanks!
In the meantime, while I'm wrapping my head around the actual implementation, I'd like to contribute to type-safety of the code.
So, in this PR I
anytype annotations and castsas anyas much as possible. I failed in some places because couldn't get how they work :)noImplicitAnyand made corresponding changes to the codeAlthough all changes in this PR are cosmetical and the logic isn't changed, there may be some breaking changes due to using more strict
unknowntype instead ofanyin some public API.