Repository navigation
Avoid setting attributes twice - #3655
Merged
Merged
Conversation
Use AttributeValueNotSet( Pcgs, group ) instead of Pcgs( group ), otherwise the SetPcgs call afterwards has no effect.
- reduce code duplication - remove a stray hole in a list - don't call SetSource / SetRange, as there are custom getters for these for mappings which gets the source / range from the family object.
fingolfin
added
topic: library
release notes: not needed
Contributor
|
Thanks for looking at these, at least one is a clear bug, and the others are definately improvements. |
ChrisJefferson
approved these changes
Sep 11, 2019
hulpke
approved these changes
Sep 12, 2019
This was referenced Jun 4, 2025
fingolfin
added a commit
that referenced
this pull request
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a few places which cause Info messages when using PR #3628 and a high enough InfoAttributes level. In the case of GeneralRestrictedMapping, it avoids a warning for an attribute where HasFOO is set (here: HasSource and HasRange), but no actual value is stored in the object: for mappings, we do this intentionally, as the Source/Range are stored in the family object.
This touches Pcgs and mappings code. Many further things could be fixed, but these seem fairly "obvious" to me.