Repository navigation
fix: large decimals that round to too many digits must fail parsing - #76
Merged
Merged
Conversation
gapple
force-pushed
the
large-decimal-rounding
branch
from
October 27, 2026 20:10
eba3646 to
59c1390
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the httpwg tests: Rounding
999999999999.9996to three decimal places goes up to1000000000000.0, which exceeds the limit of 12 integer-portion digitsThe check on integer-portion digits took place on the original number before rounding.
As defined in the spec, move it to the rounded value.