A filesystem decides for itself what a name may hold, and S3 does not ask. Windows forbids : * ? < > | " and a trailing space or dot; every filesystem forbids a NUL. Path.resolve answers each with InvalidPathException, which nothing caught, so a key S3 takes reached the caller as a 500 InternalError -- a fault laid at S3Proxy's door for a request that was never going to work, and one the caller is invited to retry forever. It is the refusal a key holding the separator already earns, so it is spelled the same way: one resolving helper now carries both, for keys and for the listing prefix alike, and answers 400 InvalidArgument naming what the filesystem objected to. The NUL makes this a fix for every host rather than for Windows -- that key was a 500 on Linux too, and the test measures it against a real temporary directory. The Windows mode this was found in is what issue #818 asks for, and the class that runs it grew this commit's cases: a Jimfs configured Windows-style walks the same code a Windows deployment walks, on every build, with no Windows host anywhere. Two defects have come out of it so far -- the separator that collapsed two keys onto one object, and this. It is worth being plain about what that mode does not reach. Windows matches names case-insensitively, so UPPER.txt and upper.txt still collapse onto one object with nothing said; refusing a write whose key differs from a stored one only in case is a decision this commit does not make. And Jimfs models the path syntax, not the system: it stored a file called CON, which Windows refuses as a device name, and it is not the provider that raised the UnsupportedOperationException in #816. Only the Windows CI of #905 reaches those. Measured: the suite passes 555 on the transient and filesystem lanes and 532 on SFTP, and the three new tests fail without the change. Fixes #818. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014pJPwDB8sUdbqTgi5xEtRx

Set up Windows CI for filesystem-nio2 storage backend #905

Description

Activity

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions