Conversation
The README named the pinned commit and then, two sentences later, said the pin lives only in mk/config.mk. The copy drifted: it read 9030b783 while GEIST_REV had moved on to b78df97f. Name the variable instead of the hash, so there is one place to read and nothing to keep in sync. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LkBr39Z2JxHU1SL63VyPC9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The README's
make depsparagraph named the pinned commit inline and then, two sentences later, said the pin lives only inmk/config.mk. Both statements cannot stay true, and the copy is the one that rots — it read9030b783, whileGEIST_REVhad already moved tob78df97f(both 2026-09-07, one commit apart).Change
Name the variable instead of the value: the paragraph now points at
mk/config.mk(GEIST_REV) and says to read it there rather than from a copy that can drift. Nothing else in the build or the fetch behaviour changes.This is the fix the README's own sentence already asked for — one source of truth, nothing to keep in sync — rather than updating the hash and waiting for the next drift.
Testing
Documentation only; no build inputs touched.
mk/config.mkis unchanged, somake depsstill fetches exactly the commit it fetched before.Noticed while comparing the documented pin against the configured one across the geisten repos.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LkBr39Z2JxHU1SL63VyPC9
Generated by Claude Code