Skip to content

ci: propose extending testnet smoke exclusion to v3-dev - #246

Draft
jmlago wants to merge 1 commit into
v3-devfrom
legatus/v3-smoke-policy
Draft

jmlago wants to merge 1 commit into
v3-devfrom
legatus/v3-smoke-policy

Conversation

@jmlago

@jmlago jmlago commented Nov 19, 2026

Copy link
Copy Markdown
Member

Proposed policy change — human review requested

PRs targeting v3-dev currently run the deployed-testnet smoke suite, while v2-dev PRs skip it. Both branches currently point to 3f6cf62 and target the resolution-kernel train, which the existing workflow documents as incompatible with the deployed pre-train testnets.

Extend the existing PR exclusion to v3-dev. This affects every future PR into that branch. Scheduled and manually dispatched smoke runs and PRs to other branches remain enabled. Cross-repository E2E remains the intended live coverage for this release line.

This is a repository-policy proposal extracted from #244 at the auditor's request. It is not required to land DXP-678: the smoke job has continue-on-error enabled. Please review independently; this PR is a draft for human review.

Evidence

https://github.com/genlayerlabs/genlayer-js/actions/runs/44430214506 timed out and was cancelled after Asimov repeatedly returned HTML instead of JSON. This proposal does not repair the endpoint.

Assumptions

  • v3-dev should inherit the same deployed-testnet exclusion as v2-dev until those testnets support the train.
  • Keep scheduled/manual smoke coverage unchanged.

Validation

The identical condition was parsed as YAML and evaluated for six cases: v2-dev/v3-dev PRs excluded; main/v1-dev PRs, schedule and workflow_dispatch enabled. Only .github/workflows/smoke.yml changes.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@danieljrc888

Copy link
Copy Markdown
Contributor

Reviewed at 70aa8de. This is correct: v3-dev was branched from v2-dev and targets the same release train, so the testnet smoke suite cannot pass on its PRs for the same reason it is skipped on v2-dev. Scheduled and manual smoke runs are unaffected. Fine to merge once a maintainer approves the policy change.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants