Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
|
Reviewed at 70aa8de. This is correct: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed policy change — human review requested
PRs targeting v3-dev currently run the deployed-testnet smoke suite, while v2-dev PRs skip it. Both branches currently point to 3f6cf62 and target the resolution-kernel train, which the existing workflow documents as incompatible with the deployed pre-train testnets.
Extend the existing PR exclusion to v3-dev. This affects every future PR into that branch. Scheduled and manually dispatched smoke runs and PRs to other branches remain enabled. Cross-repository E2E remains the intended live coverage for this release line.
This is a repository-policy proposal extracted from #244 at the auditor's request. It is not required to land DXP-678: the smoke job has continue-on-error enabled. Please review independently; this PR is a draft for human review.
Evidence
https://github.com/genlayerlabs/genlayer-js/actions/runs/44430214506 timed out and was cancelled after Asimov repeatedly returned HTML instead of JSON. This proposal does not repair the endpoint.
Assumptions
Validation
The identical condition was parsed as YAML and evaluated for six cases: v2-dev/v3-dev PRs excluded; main/v1-dev PRs, schedule and workflow_dispatch enabled. Only .github/workflows/smoke.yml changes.