Skip to content

feat: add appeal transaction action - #24

Closed
danieljrc888 wants to merge 56 commits into
mainfrom
feat/submit-appeal-action
Closed

danieljrc888 wants to merge 56 commits into
mainfrom
feat/submit-appeal-action

Conversation

@danieljrc888

@danieljrc888 danieljrc888 commented Apr 3, 2025 •

Copy link
Copy Markdown
Contributor

Closes DXP-196
Partially fix DXP-336

What

  • Added appeal transaction action
  • Estimate gas in transaction preparation function

danieljrc888 and others added 21 commits March 26, 2025 16:16
style: tests
* feat: add account functions

* refactor: convert accounts folder to module

* refactor: rename attributo to not override BaseEth.account

* feat: add tests

* feat: add account actions
* feat: add initialize consensus smart contract method

* feat: initialize consensus smart contract on client creation

* feat: add transaction configs

* feat: add contract actions

* feat: add transaction actions

* feat: add actions to client
@danieljrc888 danieljrc888 added enhancement New feature or request GenLayerPY labels Apr 3, 2025
@danieljrc888 danieljrc888 self-assigned this Apr 3, 2025
@danieljrc888
danieljrc888 requested a review from cristiam86 April 3, 2025 20:13

Copy link
Copy Markdown
Contributor

@danielrc888 this should no longer be blocked

@danieljrc888

Copy link
Copy Markdown
Contributor Author

@cristiam86 thanks for the clarification. Is this the same as this issue in linear ?

@cristiam86

Copy link
Copy Markdown
Contributor

@cristiam86 thanks for the clarification. Is this the same as this issue in linear ?

yes! I just marked them as duplicates

@danieljrc888

danieljrc888 commented May 27, 2025 •

Copy link
Copy Markdown
Contributor Author

Ok, thanks. I'll work on this later today or tomorrow at the latest.

@danieljrc888
danieljrc888 force-pushed the feat/submit-appeal-action branch from 0a43f40 to 5106606 Compare May 27, 2025 21:03
@danieljrc888

Copy link
Copy Markdown
Contributor Author

Submit appeal is sending a tx with correct params but is failing. I'll do some research.

image

@linear

linear Bot commented May 28, 2025

Copy link
Copy Markdown
DXP-336 eth_sendRawTransaction out of gas for testcase

When I run this command in main to run that specific test then when it is sending the transactions, the consensus_service/hardhat is throwing this error. The test continues and passes but it is weird. When I send a transaction through the studio frontend then it works and the gas is set to 30000000 (I don't know where, maybe genlayer-js). I did not check if it happens for all integration testcases.

gltest --contracts-dir . tests/integration/contract_examples/test_intelligent_oracle_factory_pattern.py::test_intelligent_oracle_factory_pattern

hardhat-1             | web3_clientVersion

hardhat-1             | eth_sendRawTransaction

hardhat-1             |

hardhat-1             |   Transaction requires at least 27480 gas but got 0

hardhat-1             |

jsonrpc-1             | [CONSENSUS_SERVICE]: Error forwarding transaction: {'code': -32000, 'message': 'Transaction requires at least 27480 gas but got 0', 'data': {'message': 'Transaction requires at least 27480 gas but got 0', 'data': None}}

@danieljrc888

Copy link
Copy Markdown
Contributor Author
  1. It works for localnet
  2. It seems that the appeal window is too short for testnet, it is only possible to appeal if the transaction has status ACCEPTED or UNDETERMINED

@danieljrc888
danieljrc888 marked this pull request as draft May 29, 2025 04:16
@cristiam86 cristiam86 closed this May 29, 2025
@cristiam86
cristiam86 deleted the feat/submit-appeal-action branch May 29, 2025 09:36
@danieljrc888
danieljrc888 restored the feat/submit-appeal-action branch May 29, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request GenLayerPY

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants