Repository navigation
Conversation
…igure-github-actions-and-workflows-part1
…s llm calls are happening in genvm
|
kstroobants
marked this pull request as ready for review
October 24, 2025 06:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Fixes https://linear.app/genlayer-labs/issue/DXP-691/configure-github-actions-and-workflows-part1
Depends on #1329 / https://linear.app/genlayer-labs/issue/DXP-683/separate-re-group-unit-tests
Summary
This PR refactors the unit test workflows to use a single, unified workflow with conditional logic that determines whether to use mocks based on PR approval status. The system now uses a single environment variable
TEST_WITH_MOCKSto control all mocking behavior.Key Changes
🔄 Workflow Consolidation
Before:
unit-tests-pr.ymlandunit-tests-pr-approved.ymlAfter:
unit-tests-pr.ymlwith intelligent trigger detection🎯 Unified Mocking Control
TEST_WITH_MOCKScontrols all mocking (LLMs, web requests, external services)TEST_WITH_MOCK_LLMSfor better clarity and consistency🔧 Enhanced Test Fixtures
The
tests/unit/conftest.pynow provides comprehensive mocking:TEST_WITH_MOCKSvariableBehavior
Regular PRs (opened, synchronized)
Approved PRs
Push to main
TEST_WITH_MOCKS=false # or true, depending on requirementsTrigger Logic
The workflow now intelligently determines when to run:
Benefits
Files Changed
.github/workflows/unit-tests-pr-approved.yml.github/workflows/unit-tests-pr.yml- Complete rewrite with trigger logictests/unit/conftest.py- Updated to useTEST_WITH_MOCKStests/unit/consensus/test_helpers.py- Updated variable name.env.example- Changed toTEST_WITH_MOCKSTesting
Run unit tests with mocking:
Run unit tests without mocking:
Migration Notes
TEST_WITH_MOCK_LLMShas been renamed toTEST_WITH_MOCKSSummary by CodeRabbit
Release Notes
New Features
Bug Fixes
Tests
Chores