Skip to content

chore(genvm): update to v0.2.11 - #1387

Merged
cristiam86 merged 4 commits into
mainfrom
chore/genvm-v0.2.11
Jan 16, 2026
Merged

cristiam86 merged 4 commits into
mainfrom
chore/genvm-v0.2.11

Conversation

@kp2pml30

@kp2pml30 kp2pml30 commented Jan 15, 2026 •

Copy link
Copy Markdown
Member

What

Updated genvm

Why

  • should help with deadlocks
  • should allow storage reads in nondet

Testing done

  • gltest tests/integration/ passed locally

Decisions made

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set a descriptive PR title compliant with conventional commits

Reviewing tips

User facing release notes

Summary by CodeRabbit

  • Chores

    • Upgraded GenVM runtime in Docker images to v0.2.11.
  • Refactor

    • Simplified contract deployment and code-storage flow for faster direct writes.
    • Streamlined execution host communication and result handling; storage changes are now applied consistently.
    • State proxy and message formats updated to improve execution reliability and feedback.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 15, 2026 •

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR rewires GenVM integration: introduces a writable state proxy for direct code storage, converts code write paths from async to sync, adds a code parameter propagated through _run_genvm/run_genvm_host, restructures host result handling, and bumps GenVM Docker images to v0.2.11. (≈50 words)

Changes

Cohort / File(s) Summary
State & Code Deployment Refactor
backend/node/base.py
_StateProxyNone now inherits StateProxyWritable; _put_code_to changed to sync (_put_code_to(self, to: StateProxyWritable, code: bytes) -> None) and writes length-prefixed code to get_code_slot(). deploy_contract and get_contract_schema now pass code through _run_genvm.
GenVM Host API & Result Handling
backend/node/genvm/base.py, backend/node/genvm/origin/base_host.py
Added StateProxyWritable and apply_storage_changes. Host/protocol changes: removal of get_calldata, storage_write, consume_result, has_result, post_event; RunHostAndProgramRes extended with result metadata and storage changes; Host.provide_result/run_genvm_host signatures accept `code: bytes
Docker GenVM Version Bump
docker-compose.yml, docker/Dockerfile.backend, docker/Dockerfile.consensus-worker
Updated GenVM tag from v0.2.7 to v0.2.11 in compose and Dockerfiles.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Node
    participant GenVM_Host
    participant StateStore

    Client->>Node: request (invoke/deploy, code?)
    Node->>GenVM_Host: run_genvm_host(message, calldata, code)
    GenVM_Host->>Node: RunHostAndProgramRes(result_kind, result_data, storage_changes, events)
    alt storage_changes non-empty
        Node->>StateStore: apply_storage_changes(storage_changes) via StateProxyWritable
    end
    Node->>Client: Receipt / ExecutionResult
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Suggested labels

run-tests, released

Suggested reviewers

  • kstroobants

Poem

🐰 I hopped through code and found a seam,
Writable hops now skip the stream,
Sync writes tuck the bytes in tight,
GenVM hums in v0.2.11 light,
A rabbit cheers for cleaner scheme! 🎉

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 5.26% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description covers essential sections (What, Why, Testing done) but lacks detail on the 'Decisions made' section and provides minimal user-facing release notes despite significant API changes. Expand the 'What' section to detail the API and behavioral changes across backend/node files; provide user-facing release notes explaining deadlock improvements and storage read support.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title clearly and specifically describes the main change: updating GenVM to version 0.2.11.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ca3ac3 and 188773d.

📒 Files selected for processing (1)
  • docker-compose.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • docker-compose.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: backend-unit-tests
  • GitHub Check: pre-commit

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kp2pml30 kp2pml30 self-assigned this Jan 15, 2026
@kp2pml30
kp2pml30 requested a review from cristiam86 January 15, 2026 12:03
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
14.4% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@cristiam86
cristiam86 merged commit b4c1a32 into main Jan 16, 2026
12 of 13 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.91.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants