Repository navigation
fix(genvm): route deploys declaring v0.2-only runners to the retained line - #1822
Conversation
… line Existing projects (Collective Memory, argue.fun, Rally) keep deploying unchanged code after the v0.123 upgrade. That code declares runners that only the retained v0.2 executor ships (e.g. py-genlayer:1jb45..., py-genlayer:1j12s...), and without a `# v0.2.x` header the manager sent it to the newest line, which ends the deploy with `runner malformed`. Top-level deploys, simulated deploys (fee estimates) and schema reads now select the retained line from the code's runner spec as well as from the header. This reverses the narrowing in #1802, which limited runner inference to children of v0.2 emitters; new deploys of code the newest line can run still get the newest line. The registry parser also reads the v0.3 `{latest, versions}` shape, so the legacy-only set is computed against the real v0.3.0-rc11 registry instead of treating every v0.3 entry as empty. Validated against the real v0.2.17 and v0.3.0-rc11 registries: argue DebateResolution/BridgeSender, Rally XID/Referral/Campaign/Shard/Factory, all 85 Rally runner.json files and CM ContentValidator select v0.2; Studio examples and integration contracts keep the newest line. Not covered: closing v0.2 deploys later needs a per-Studio flag gating this inference, rejecting explicit v0.2 selectors and dropping v0.2 pins on cascade. Runner aliases and unknown hashes still go to the newest line.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
/run-e2e all |
|
E2E status was updated. Follow the current E2E and merge checks on this PR. Detailed diagnostics are available internally. |
Problem and outcome
Projects already on hosted Studios (Collective Memory, argue.fun, Rally) keep deploying their current, unchanged contract code after the v0.123 upgrade. That code declares runners that only the retained v0.2 executor ships (for example
py-genlayer:1jb45…,py-genlayer:1j12s…). On rc.11 such a deploy only reaches v0.2 when its first line is# v0.2.x; otherwise the manager sends it to the newest line, which ends it withrunner malformed. Every project would have had to edit its code before the upgrade.With this change, top-level deploys, simulated deploys (fee estimates) and schema reads also select the retained line when the code's runner spec (zip
runner.json, else the leading comment block) declares a runner shipped only by the v0.2 line. The header keeps working. Code the newest line can run still gets the newest line, so nothing that works today changes line; only deploys that used to fail withrunner malformednow run on v0.2.Policy: this reverses the narrowing in #1802 ("new deployments run on the newest GenVM line"), which limited runner inference to children of v0.2 emitters. It matches the compat-window proposal (allow new v0.2 deploys by runner during the window, block them in a later release). @MuncleUscles please sign off on the policy change explicitly.
Implementation and validation
legacy_executor_selector_for_codenow returns the legacy selector for the header or a declared v0.2-only runner;legacy_executor_selector_for_child_codeand_emitter_genvm_executor_selectorare gone (children use the same function, the emitter check is dropped).{latest, versions}shape. Before, every v0.3 entry parsed as empty, so the "v0.2-only" set was not really computed against v0.3.test_legacy_contract_without_manual_executor_selectionis parametrized over# v0.2.16, no header and# v0.1.0.__init__and zip), all 85 Rallyrunner.jsonfiles and CM ContentValidator select v0.2; Studio examples and integration contracts keep the newest line.tests/unit1814 passed, 7 skipped.Rollback: revert this PR; behavior returns to rc.11 (header required).
Not covered
_validate_genvm_executor_selectorand drops v0.2 pins when cascading in_child_sim_config. Without a header there is no visible marker in the code, so the flag must cover the runner path._child_sim_configstill freezes an inferred pin at emission even thoughtransaction_genvm_executor_selectorwould infer it too; kept on purpose.