Skip to content

fix(genvm): route deploys declaring v0.2-only runners to the retained line - #1822

Merged
danieljrc888 merged 1 commit into
v0.123-devfrom
fix/genvm-route-legacy-runner-deploys
Nov 11, 2026
Merged

danieljrc888 merged 1 commit into
v0.123-devfrom
fix/genvm-route-legacy-runner-deploys

Conversation

@danieljrc888

Copy link
Copy Markdown
Contributor

Problem and outcome

Projects already on hosted Studios (Collective Memory, argue.fun, Rally) keep deploying their current, unchanged contract code after the v0.123 upgrade. That code declares runners that only the retained v0.2 executor ships (for example py-genlayer:1jb45…, py-genlayer:1j12s…). On rc.11 such a deploy only reaches v0.2 when its first line is # v0.2.x; otherwise the manager sends it to the newest line, which ends it with runner malformed. Every project would have had to edit its code before the upgrade.

With this change, top-level deploys, simulated deploys (fee estimates) and schema reads also select the retained line when the code's runner spec (zip runner.json, else the leading comment block) declares a runner shipped only by the v0.2 line. The header keeps working. Code the newest line can run still gets the newest line, so nothing that works today changes line; only deploys that used to fail with runner malformed now run on v0.2.

Policy: this reverses the narrowing in #1802 ("new deployments run on the newest GenVM line"), which limited runner inference to children of v0.2 emitters. It matches the compat-window proposal (allow new v0.2 deploys by runner during the window, block them in a later release). @MuncleUscles please sign off on the policy change explicitly.

Implementation and validation

  • legacy_executor_selector_for_code now returns the legacy selector for the header or a declared v0.2-only runner; legacy_executor_selector_for_child_code and _emitter_genvm_executor_selector are gone (children use the same function, the emitter check is dropped).
  • The registry parser reads the v0.3 {latest, versions} shape. Before, every v0.3 entry parsed as empty, so the "v0.2-only" set was not really computed against v0.3.
  • Unit tests use both real registry shapes (v0.2.17 list, v0.3.0-rc11 dict) and cover top-level, simulated, schema and child deploys; integration test test_legacy_contract_without_manual_executor_selection is parametrized over # v0.2.16, no header and # v0.1.0.
  • Checked against the real v0.2.17 and v0.3.0-rc11 registries: argue DebateResolution/BridgeSender, Rally XID/Referral/Campaign/Shard/CampaignFactory (__init__ and zip), all 85 Rally runner.json files and CM ContentValidator select v0.2; Studio examples and integration contracts keep the newest line.
  • Local: black, ruff, pre-commit; tests/unit 1814 passed, 7 skipped.

Rollback: revert this PR; behavior returns to rc.11 (header required).

Not covered

  • Closing v0.2 deploys later needs a per-Studio flag that gates this inference, rejects explicit v0.2 selectors in _validate_genvm_executor_selector and drops v0.2 pins when cascading in _child_sim_config. Without a header there is no visible marker in the code, so the flag must cover the runner path.
  • Runner aliases and unknown hashes still go to the newest line (unchanged from rc.11).
  • _child_sim_config still freezes an inferred pin at emission even though transaction_genvm_executor_selector would infer it too; kept on purpose.

… line

Existing projects (Collective Memory, argue.fun, Rally) keep deploying
unchanged code after the v0.123 upgrade. That code declares runners that
only the retained v0.2 executor ships (e.g. py-genlayer:1jb45...,
py-genlayer:1j12s...), and without a `# v0.2.x` header the manager sent it
to the newest line, which ends the deploy with `runner malformed`.

Top-level deploys, simulated deploys (fee estimates) and schema reads now
select the retained line from the code's runner spec as well as from the
header. This reverses the narrowing in #1802, which limited runner
inference to children of v0.2 emitters; new deploys of code the newest
line can run still get the newest line.

The registry parser also reads the v0.3 `{latest, versions}` shape, so the
legacy-only set is computed against the real v0.3.0-rc11 registry instead
of treating every v0.3 entry as empty.

Validated against the real v0.2.17 and v0.3.0-rc11 registries: argue
DebateResolution/BridgeSender, Rally XID/Referral/Campaign/Shard/Factory,
all 85 Rally runner.json files and CM ContentValidator select v0.2;
Studio examples and integration contracts keep the newest line.

Not covered: closing v0.2 deploys later needs a per-Studio flag gating this
inference, rejecting explicit v0.2 selectors and dropping v0.2 pins on
cascade. Runner aliases and unknown hashes still go to the newest line.
@danieljrc888 danieljrc888 self-assigned this Nov 10, 2026
@coderabbitai

coderabbitai Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c44fc5cc-948e-4943-8e44-4ae60b80943e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T20:47:12.908202Z c9afc27 PR opened
🔒 Security Review ✅ Completed 2026-11-10T20:52:46.390449Z c9afc27 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@danieljrc888

Copy link
Copy Markdown
Contributor Author

/run-e2e all

@ci-core-e2e-runner

Copy link
Copy Markdown
Contributor

E2E status was updated. Follow the current E2E and merge checks on this PR. Detailed diagnostics are available internally.

@danieljrc888
danieljrc888 merged commit 2274e54 into v0.123-dev Nov 11, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant