You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(executor): gate runners on availability time and audit dependencies nightly ✨ - #69
Carries the executor-side work for that manager PR. The manager branch update fast-forwards v0.3-dev to its pinned commit after landing.
Summary by CodeRabbit
New Features
Runner versions can now include an availability date and identify a version they supersede.
Runner selection checks whether a version was available at the transaction timestamp. Versions not yet available are rejected, while versions without an availability date remain eligible.
Bug Fixes
Runner registry checks now validate version entries and their associated package hashes.
No actionable comments were generated in the recent review.
Walkthrough
The runner manifest now represents runner versions in all.json, including optional availability and supersession metadata. The executor loads this registry and checks builtin runner availability against the transaction timestamp during resolution.
Changes: Runner Registry and Availability
Layer / File(s)
Summary
Runner metadata and manifest output runners/support/default.nix, runners/support/versions/current.nix, runners/default.nix, executor/default.nix, .genvm-tool.py
Runner pin processing carries optional available-after and supersedes fields into runner records. Manifest comments, installation, and tooling documentation refer to all.json.
Typed registry loading and consumers executor/src/runners/cache.rs, executor/src/exe/check.rs, executor/src/exe/precompile.rs, executor/src/runners/mod.rs
The executor parses and validates a typed registry from all.json. Checks and precompilation iterate each runner entry’s version keys.
The supervisor receives the transaction timestamp. Builtin runner resolution rejects missing or not-yet-available versions with a malformed-runner error. Tests cover gated and ungated versions.
This change gates packaged runner versions on an availability time taken from the transaction timestamp. No concrete merge-blocking defect was established. One open item for the owners: confirm that the JSON emitted for all.json uses the key names the Rust registry parser expects.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title "feat(executor): gate runners on availability time and audit dependencies nightly ✨" names the main change. The summary shows the executor now gates packaged runners on an availability times…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "feat(executor): gate runners on availability time and audit dependencies nightly ✨" names the main change. The summary shows the executor now gates packaged runners on an availability timestamp (available_after, supersedes, and the registry rework in executor/src/runners/cache.rs, plus resolve_runner_id checks in executor/src/rt/supervisor/actions.rs). The title's second clause, "audit dependencies nightly", does not match anything in the raw summary. The title also contains an emoji, which the title guidelines discourage. The core claim is supported, so the title is partially aligned rather than unrelated.
Full details: Docstring Coverage
Explanation
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 12 functions across 9 files. (4 skipped: 4 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Some tools did not complete. Review the errors below.
Clippy (1.99.0)
Clippy execution failed
Tip
🎯 Customize your risk assessments
Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.
✅ Automatic approvals, with your rules
Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 2e094c6 and 536c58f.
Files ignored due to path filters: 5
executor/tests/precompile_lookup.rs is excluded by !**/tests/**
executor/tests/registry.rs is excluded by !**/tests/**
tests/integration/runner/dup-dependency/dup-dependency-prepare.py is excluded by !**/tests/**
tests/integration/runner/dup-dependency/dup-dependency.jsonnet is excluded by !**/tests/**
tests/integration/runner/lock/prepare.py is excluded by !**/tests/**
Files selected for processing: 13
.genvm-tool.py
executor/default.nix
executor/src/exe/check.rs
executor/src/exe/precompile.rs
executor/src/lib.rs
executor/src/rt/supervisor/actions.rs
executor/src/rt/supervisor/mod.rs
executor/src/runners/cache.rs
executor/src/runners/mod.rs
executor/src/wasi/genlayer_sdk/tests.rs
runners/default.nix
runners/support/default.nix
runners/support/versions/current.nix
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened executor mirror of genlayerlabs/genvm-manager#82.
Carries the executor-side work for that manager PR. The manager branch update fast-forwards
v0.3-devto its pinned commit after landing.Summary by CodeRabbit