Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 3
Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delivery Context
Review layer above #96; do not run
/mergeor/genvm-fast-forwardhere until #96 lands, then retarget tov0.6-devProblem and Outcome
A fee kind can charge several buckets, e.g.
nondet_outputcharges[execution_data_gas, nondet_outputs]. Every fee the executor reports to the contract or host (CostVec::reported_fee) is the first bucket's cost, butdata_fees_consumedin the execution hash summed all of a kind's buckets. Now it reports only the first bucket, matching the other reported feesImplementation and Validation
DataLimit::consumedreadstotal_consumed[0]per kindfee_bucket_accountingtest: a 2-bucket kind with start[2, 5]and delta[3, 7]now reports 5, not 17.hashsidecar regenerated; full v0.4 sweep green, includingfuzz, web and LLM cases