Skip to content

fix(executor): report only the first bucket's consumption in data_fees_consumed 🐛 - #97

Open
kp2pml30 wants to merge 1 commit into
fix/v04-audit-hardeningfrom
fix/reported-fee-consumed
Open

kp2pml30 wants to merge 1 commit into
fix/v04-audit-hardeningfrom
fix/reported-fee-consumed

Conversation

@kp2pml30

Copy link
Copy Markdown
Member

Delivery Context

Review layer above #96; do not run /merge or /genvm-fast-forward here until #96 lands, then retarget to v0.6-dev

Problem and Outcome

A fee kind can charge several buckets, e.g. nondet_output charges [execution_data_gas, nondet_outputs]. Every fee the executor reports to the contract or host (CostVec::reported_fee) is the first bucket's cost, but data_fees_consumed in the execution hash summed all of a kind's buckets. Now it reports only the first bucket, matching the other reported fees

Implementation and Validation

  1. DataLimit::consumed reads total_consumed[0] per kind
  2. New fee_bucket_accounting test: a 2-bucket kind with start [2, 5] and delta [3, 7] now reports 5, not 17
  3. Every v0.4 .hash sidecar regenerated; full v0.4 sweep green, including fuzz, web and LLM cases

@kp2pml30
kp2pml30 requested a review from jmlago as a code owner November 18, 2026 12:29
@kp2pml30 kp2pml30 self-assigned this Nov 18, 2026
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 3

  • main
  • v\d+.\d+
  • v\d+.\d+-dev

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant