Skip to content

smoke: the review lifecycle is not covered by any publish gate #145

Open

Description

@shubham773

Context

Public apps and the review lifecycle (brevo app submit / app status / app withdraw) ship in every build (#143), and the public smoke suite exists and is in the live set — but no blocking lane runs it:

  • smoke-pre-merge.yml covers it via suite: private,public,ui,init, but that lane is non_blocking and runs against=local.
  • smoke-post-merge.yml — the lane that verifies the published package — stays pinned at suite: private,ui (plus function), so a publish gate never touches the review lifecycle.

This was a deliberate deferral (per CLAUDE.md, a suite only ever run on a dev machine has not been proven headless), previously tracked in the branch-local docs.md, which was deleted before the merge to main — this issue is its new home.

Action

  1. Run the public suite from smoke.yml's manual dispatch button on ubuntu-latest to prove it headless.
  2. If green, widen smoke-post-merge.yml's pinned suite to include public — a deliberate edit there, per the comment in that workflow.
  3. If not green, fix what headless execution surfaces first.

Until then, a release could regress submit/status/withdraw and every gate would still report green.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions