Skip to content

Add withErrorHandling to build-only tool logic functions #334

Description

@cameroncooke

Context

buildDeviceLogic in build_device.ts, build_simLogic in build_sim.ts, and buildMacOSLogic in build_macos.ts are not wrapped in withErrorHandling. If startBuildPipeline or executeXcodeBuildCommand throw an unexpected error (not a build failure, but e.g. a filesystem error), it would propagate unhandled.

The build_run_* variants do use withErrorHandling because they have additional post-build steps. The build-only tools rely on executeXcodeBuildCommand returning error information in buildResult.isError rather than throwing.

Flagged by Sentry bot on PR #325.

Recommendation

Add withErrorHandling wrappers to all three build-only logic functions for consistency and robustness against unexpected throws.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions