fix(init): stop reporting cancelled wizard prompts#1075
Merged
Conversation
Contributor
|
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 4847 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 81.40% 81.39% -0.01%
==========================================
Files 372 372 —
Lines 26054 26052 -2
Branches 16994 16994 —
==========================================
+ Hits 21210 21205 -5
- Misses 4844 4847 +3
- Partials 1773 1775 +2Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stops treating intentional
sentry initprompt cancellations as Sentry error issues. The wizard still recordswizard.outcome=bailed, shows the cancellation feedback, and exits cleanly, but no longer callscaptureExceptionforWizardCancelledError.Adds regression coverage for both welcome-screen cancellation and mid-step wizard cancellation so this does not come back as telemetry noise.
Test Plan
pnpm exec vitest run test/lib/init/wizard-runner.test.ts --testNamePattern "cancels cleanly from rich welcome screen|tears down forwarding and stops the spinner on cancellation|aborts the MastraClient signal on cancellation"pnpm exec biome check src/lib/init/wizard-runner.ts test/lib/init/wizard-runner.test.tsSentry issue: CLI-1P9