Repository navigation
Conversation
llirik0
requested review from
a team,
NinjaLikesCheez,
itaybre,
noahsmartin and
philprime
as code owners
September 10, 2026 17:40
llirik0
added a commit
to llirik0/sentry-cocoa
that referenced
this pull request
Sep 10, 2026
NinjaLikesCheez
approved these changes
Sep 11, 2026
NinjaLikesCheez
left a comment
Member
There was a problem hiding this comment.
LGTM - just pinged Phil on one question about the default value
llirik0
added a commit
to llirik0/sentry-cocoa
that referenced
this pull request
Sep 14, 2026
llirik0
force-pushed
the
feat/breadcrumb-text-extraction
branch
from
September 14, 2026 02:58
ae3e5a8 to
179ef52
Compare
philprime
reviewed
Sep 15, 2026
philprime
left a comment
Member
There was a problem hiding this comment.
Left a couple of comments to consider.
llirik0
added a commit
to llirik0/sentry-cocoa
that referenced
this pull request
Sep 19, 2026
llirik0
force-pushed
the
feat/breadcrumb-text-extraction
branch
from
September 19, 2026 20:06
175d021 to
c000e31
Compare
llirik0
force-pushed
the
feat/breadcrumb-text-extraction
branch
from
October 4, 2026 00:40
c000e31 to
63d0283
Compare
9 tasks done
llirik0
added a commit
to llirik0/sentry-cocoa
that referenced
this pull request
Oct 7, 2026
itaybre
reviewed
Oct 9, 2026
philprime
requested changes
Oct 12, 2026
philprime
left a comment
Member
There was a problem hiding this comment.
Thank you for this work so far. Please see this comment on why the PR is currently considered as blocked:
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Add the dedicated experimental
enableBreadcrumbTextExtractionprivacy option requested in #8105.options.experimental.enableBreadcrumbTextExtractionon supported UIKit platforms.false, so child-view text extraction is explicitly opt-in.SentryObjCExperimentalOptions.SentryBreadcrumbTrackerwhen automatic breadcrumb tracking is installed.initReportAccessibilityIdentifier:selector and existing directUIButtontitle behavior for compatibility.breadcrumbTextExtractionthroughSentryEnabledFeaturesBuilder.This PR intentionally does not copy child-view traversal from #8974. It establishes the dedicated configuration path first so #8974 can be rebased and gate only its final child-text fallback without coupling it to
reportAccessibilityIdentifier.Closes #8105
💡 Motivation and Context
Visible child text can contain user-provided or sensitive content. A separate experimental, disabled-by-default option keeps child-text extraction independent from the existing accessibility-identifier privacy setting and allows applications to prevent traversal before it is attempted.
💚 How did you test it?
Strict RED -> GREEN coverage verified:
false.SentryObjCExperimentalOptions, defaults it tofalse, and retains assigned values.breadcrumbTextExtractionwhen enabled.UIButton.currentTitlebreadcrumb label.Final verification:
make formatmake lint-stagedmake analyzegit diff --checkThe full repository lint currently also reports two pre-existing violations in untouched CrashE2E files on
main; all staged files pass lint. Public API snapshots were updated for standard and V10 SDKs. The canonical combined generator requires Xcode 16, which is unavailable locally under Xcode 26.3; snapshot ownership was structurally verified, and standard/V10 builds plus Swift and Objective-C API tests pass.📝 Checklist
SentryObjCExperimentalOptions.