Repository navigation
feat: Combine attachAllThreads with scope block - #9424
Draft
sentry-junior[bot] wants to merge 3 commits into
Draft
sentry-junior[bot] wants to merge 3 commits into
sentry-junior[bot] wants to merge 3 commits into
Conversation
Add capture overloads for events, errors, exceptions, and messages that accept both a per-call attachAllThreads override and a scope block, in Swift and through SentryObjC. Co-Authored-By: Angelo de Voer <angelo.devoer@sentry.io>
Co-Authored-By: Angelo de Voer <angelo.devoer@sentry.io>
Contributor
|
Regenerate the API snapshots for the new capture overloads, using the output of the API Stability check.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
capture(…:attachAllThreads:block:)overloads for events, errors, exceptions, and messages, so a single call can attach all threads and mutate a per-call scope (for example, adding tags to a custom app hang report).Today
attachAllThreadsand the scope block are separate overloads, so callers have to either enableattachAllThreadsglobally or set tags viaconfigureScopeand clean them up afterwards.The new methods clone the current scope, apply the block, and forward the
attachAllThreadsoverride, same as the existinghint:block:variants. They're also exposed throughSentryObjC(captureError:attachAllThreads:withScopeBlock:etc.).Draft because
sdk_api.json,sdk_api_objc.json, andsdk_api_objc_v10.jsonstill need regenerating withmake generate-public-apion macOS.Closes #8538
via ADV.
--
View Junior Session [Sentry]