feat!: make Scope.Environment non-nullable

[jamescrosswell]

Summary

Scope.Environment is now declared as string rather than string?.

#5365 made the setter revert null to SentryOptions.Environment, but the property could still return null: a scope whose environment was never set had a null backing field, and SentryOptions.Environment is itself nullable. To make the non-nullable declaration truthful:

• The getter falls back to SettingLocator.GetEnvironment() (options → SENTRY_ENVIRONMENT → production/debug), the same value the Enricher already stamps on events.
• The setter keeps accepting null ([AllowNull], so it still satisfies IEventLike.Environment) and resets to that resolved default.
• Scope.Apply copies only an explicitly set environment between scopes. Otherwise the non-null getter would make ??= never copy onto a cloned scope.

Changelog Entry

Scope.Environment is now non-nullable (#5587)

Notes for review

• Breaking change (public API signature), hence targeting version7.
• Side effect: Apply to an event now writes the resolved default environment from the scope rather than leaving it for the Enricher. The value is identical.
• The Populate_RouteData_SetToScope snapshot now includes Environment: production, since serializing a scope reads the resolved value.
• Apply_Environment_Null asserted a target scope's environment stays null, which is no longer possible. It now asserts the options fallback.

Closes #5388

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (version7@8d4f28b). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
src/Sentry/Scope.cs	85.71%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             version7    #5587   +/-   ##
===========================================
  Coverage            ?   74.77%           
===========================================
  Files               ?      515           
  Lines               ?    18908           
  Branches            ?     3691           
===========================================
  Hits                ?    14138           
  Misses              ?     3893           
  Partials            ?      877           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jamescrosswell]

@ric-oliv tbh not sure we even really need this change. If it's too much effort, I'm OK to close both the PR and the open issue as won't do.

[jamescrosswell]

@bitsandfoxes would this cause any problems for you guys? Per my comment above to Ricardo, I'm not dead set on doing this if we don't want to.

[ric-oliv]

@jamescrosswell
I guess is fair to bring this in... The getter can no longer return null, so the type should say so :)

unless @bitsandfoxes sees any reason not to.

[jamescrosswell]

Just need to decide what we're doing about #5197 (comment) as if would render these changes unnecessary...

[jamescrosswell]

Made redundant/inappropriate by #5197