[jamescrosswell]

Changelog Entry

• Envelope.FromEvent, Envelope.FromFeedback and Envelope.FromTransaction now take the IDiagnosticLogger as their last parameter, after attachments (and sessionUpdate). This only affects code that creates envelopes directly and passes these arguments positionally; those calls no longer compile, so reorder the arguments or pass them by name.

  // Before
  Envelope.FromEvent(@event, logger, attachments, sessionUpdate);
  Envelope.FromTransaction(transaction, logger, attachments);
  
  // After
  Envelope.FromEvent(@event, attachments, sessionUpdate, logger);
  Envelope.FromTransaction(transaction, attachments, logger);

Summary

Moves the IDiagnosticLogger parameter of the public Envelope factory methods to the end, so the parameters that affect what goes into the envelope come first:

- FromEvent(SentryEvent @event, IDiagnosticLogger? logger = null, IReadOnlyCollection<SentryAttachment>? attachments = null, SessionUpdate? sessionUpdate = null)
+ FromEvent(SentryEvent @event, IReadOnlyCollection<SentryAttachment>? attachments = null, SessionUpdate? sessionUpdate = null, IDiagnosticLogger? logger = null)

- FromFeedback(SentryEvent @event, IDiagnosticLogger? logger = null, IReadOnlyCollection<SentryAttachment>? attachments = null, SessionUpdate? sessionUpdate = null)
+ FromFeedback(SentryEvent @event, IReadOnlyCollection<SentryAttachment>? attachments = null, SessionUpdate? sessionUpdate = null, IDiagnosticLogger? logger = null)

- FromTransaction(SentryTransaction transaction, IDiagnosticLogger? logger = null, IReadOnlyCollection<SentryAttachment>? attachments = null)
+ FromTransaction(SentryTransaction transaction, IReadOnlyCollection<SentryAttachment>? attachments = null, IDiagnosticLogger? logger = null)

The issue only asks for attachments to come before logger. Putting logger last in all three methods, after sessionUpdate too, gives every factory the same shape.

A positional call written against the old order can't silently bind to the wrong parameter: the argument types no longer line up, so it fails to compile.

Notes

• sentry-unity only calls Envelope.FromEvent(new SentryEvent()), so it is unaffected.
• ApiApprovalTests.Run.Net4_8.verified.txt can't be regenerated on macOS, so it was edited by hand with the same line changes the other TFMs produced.

Closes #5379

🤖 Generated with Claude Code

[jamescrosswell]

@ric-oliv even though this technically touches public types and is a breaking change, in practice I doubt many SDK users are using these types (you can see there were no changes to any of our samples projects as a result of the change, for example).

[ric-oliv]

Looks good!