Skip to content

build: drop the prerelease VersionSuffix on version7 #5747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 1 commit into from
Oct 19, 2026
Merged

build: drop the prerelease VersionSuffix on version7 #5747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

<PropertyGroup>
<VersionPrefix>7.0.0</VersionPrefix>
<VersionSuffix>prerelease</VersionSuffix>

@cursor cursor Bot Oct 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stable pack version breaks prerelease deps

High Severity

Removing VersionSuffix leaves VersionPrefix at 7.0.0, so Release packs are a stable version. Packable src projects still reference 11.0.0-rc.* Microsoft packages, so NU5104 is promoted by TreatWarningsAsErrors and CI dotnet pack fails until craft rewrites the prefix.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit dc426e6. Configure here.

@jamescrosswell jamescrosswell Oct 19, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this broke Release packs on version7. Fixed in 84ffcc2 on #5748: the prerelease suffix is back, but only while VersionPrefix has no label of its own, so day-to-day builds pack as 7.0.0-prerelease and craft's bump still publishes exactly 7.0.0-rc.2. The line has to be removed for 7.0.0 GA.

<LangVersion>14.0</LangVersion>
<AccelerateBuildsInVisualStudio>true</AccelerateBuildsInVisualStudio>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
Expand Down
Loading