Skip to content

Add addToTransactions to Attachment #1185

Closed
#1191
Closed
Add addToTransactions to Attachment#1185
#1191
Assignees
philippsuess
Labels
performancePerformance API issues
Milestone
4.0.0

Description

@philippsuess
philippsuess
opened on Jan 19, 2021

The SentryClient currently adds attachments to transactions

sentry-java/sentry/src/main/java/io/sentry/SentryClient.java

Lines 359 to 360 in 2f8360a

final SentryEnvelope envelope =
buildEnvelope(sentryTransaction, getAttachmentsFromScope(scope));

This can add a huge overhead when putting large attachments to the scope. In order to avoid this, we can add addToTransactions to attachments and set the default to false. The Python SDK already has this flag.

Activity

  1. philippsuess
    added this to the 4.0.0 milestone on Jan 19, 2021
  2. philippsuess
    added
    enhancement
    on Jan 19, 2021
  3. philippsuess
    changed the title [-]Add addToTransaction to Attachments[/-] [+]Add addToTransactions to Attachments[/+] on Jan 19, 2021
  4. marandaneto
    added
    performancePerformance API issues
    on Jan 19, 2021

  5. bruno-garcia commented on Jan 19, 2021

    @bruno-garcia
    bruno-garcia
    on Jan 19, 2021
    Member

    @philipphofmann we plan to release 4.0 next week, is this going to make into it?

  6. philippsuess commented on Jan 20, 2021

    @philippsuess
    philippsuess
    on Jan 20, 2021
    Author

    @bruno-garcia I can take care of it.

  7. philippsuess
    self-assigned this
    on Jan 20, 2021

  8. bruno-garcia commented on Jan 20, 2021

    @bruno-garcia
    bruno-garcia
    on Jan 20, 2021
    Member

    Thanks @philipphofmann !

  9. philippsuess
    added a commit that references this issue on Jan 21, 2021

    feat: Add addToTransactions to Attachment

    48c50de
  10. philippsuess
    changed the title [-]Add addToTransactions to Attachments[/-] [+]Add addToTransactions to Attachment[/+] on Jan 21, 2021
  11. philippsuess
    added a commit that references this issue on Jan 21, 2021

    feat: Add addToTransactions to Attachment

    765144c
  12. philippsuess
    closed this as completedin #1191on Jan 21, 2021
  13. philippsuess
    added a commit that references this issue on Jan 21, 2021

    feat: Add addToTransactions to Attachment (#1191)

    d0502db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

performancePerformance API issues

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions