Skip to content

Check where we are catching Throwable #5513

Description

@runningcode

We shouldn't catch Throwable since that could be an OOMException or a StackOverflowException. We should audit all places where we catch Throwable

  1. Ship this in the next major version
  2. Notify downstream SDKs (gaming) of potential side effects

Activity

  1. linear-code commented on Jun 8, 2026

    @linear-code
  2. romtsn commented on Jun 8, 2026

    @romtsn
    Contributor

    There are cases, where I think it's on purpose to catch LinkageError/AbstractMethodError/NoSuchMethodError, since there can be a backward/forward compatibility codepath.

    There was also a deliberate decision to do this across the SDK to also cover gaming SDKs which throw Errors (afair), see #1806 for more context.

    We should keep those two^ in mind when doing the audit.

  3. removed their assignment
    on Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions