Skip to content

Run sentry-cli without a shell so arguments are passed as-is - #288

Draft
lbloder wants to merge 2 commits into
mainfrom
fix/run-sentry-cli-without-shell
Draft

lbloder wants to merge 2 commits into
mainfrom
fix/run-sentry-cli-without-shell

Conversation

@lbloder

@lbloder lbloder commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

📜 Description

Moves the sentry-cli execution from using the shell to directly executing via ant. This improves character escaping and handles OS-specific execution.

💡 Motivation and Context

So far only spaces have been escaped to provide Windows support. Using ant execution and passing an argument list provides a more complete solution and avoids shell interpolation issues entirely.

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@lbloder

lbloder commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

@sentry review

@lbloder

lbloder commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit b9375de. Configure here.

@adinauer adinauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants