Skip to content

Do not follow symlinks when collecting sources - #290

Draft
lbloder wants to merge 5 commits into
fix/pass-auth-token-as-env-varfrom
fix/do-not-follow-symlinks
Draft

lbloder wants to merge 5 commits into
fix/pass-auth-token-as-env-varfrom
fix/do-not-follow-symlinks

Conversation

@lbloder

@lbloder lbloder commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

📜 Description

Symlinks are now ignored when collecting sources.
This PR also fixes previously unclosed filestreams which could lead to issues on windows as the file stayed locked.

💡 Motivation and Context

Following symlinks outside the project could potentially lead to leaked resources in the bundle.

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@lbloder

lbloder commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

@sentry review

@lbloder

lbloder commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 1dae018. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant