Skip to content

Investigate potential leaked spans in strawberry integration #6309

Description

@ericapisani

During the span-first conversion, comments like these were raised for the on_parse and on_validate methods within the integration for a pre-existing pattern that may be leaking spans.

Investigate and fix assuming that the code review bots are correct.

Activity

  1. self-assigned this
    on May 20, 2026
  2. linear-code commented on May 20, 2026

    @linear-code
  3. sentrivana commented on May 21, 2026

    @sentrivana
    Contributor

    I don't know if strawberry already handles potential exceptions internally, but in any case definitely wouldn't hurt to wrap the thing in a try: and close the span in finally:.

  4. added a commit that references this issue on May 22, 2026
    4446ec0
  5. added a commit that references this issue on Aug 9, 2026
    a26952a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions