Skip to content

feat(feedback): show issue details' TraceDataSection in feedback details #76372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aliu39 wants to merge 8 commits into from
Closed

feat(feedback): show issue details' TraceDataSection in feedback details #76372

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eb96955
(WIP/has hooks error) First draft using TraceDataSection and hiding i…
aliu39 Aug 15, 2024
e5de215
Abstract timeline to its own component
aliu39 Aug 16, 2024
bb0aee5
Use isLoading and Error, and comment on jest test
aliu39 Aug 16, 2024
4dec678
Compare crashReportId with oneOtherIssueEvent.id
aliu39 Aug 16, 2024
cedcdb4
Move to top, below msg, and rm section header
aliu39 Aug 16, 2024
0f80528
Fix bug when crashreportid undef and hide when no other events
aliu39 Aug 16, 2024
103fb25
Merge branch 'master' into aliu/feedback-trace
aliu39 Aug 26, 2024
9e05c7a
Merge branch 'master' of github.com:getsentry/sentry into aliu/feedba…
aliu39 Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions static/app/components/feedback/feedbackItem/feedbackItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ import type {Event} from 'sentry/types/event';
import type {Group} from 'sentry/types/group';
import type {FeedbackIssue} from 'sentry/utils/feedback/types';
import useOrganization from 'sentry/utils/useOrganization';
import {TraceDataSection as IssueDetailsTraceDataSection} from 'sentry/views/issueDetails/traceDataSection';
import {useTraceTimelineEvents} from 'sentry/views/issueDetails/traceTimeline/useTraceTimelineEvents';

interface Props {
eventData: Event | undefined;
Expand Down Expand Up @@ -59,6 +61,14 @@ export default function FeedbackItem({feedbackItem, eventData, tags}: Props) {
<MessageSection eventData={eventData} feedbackItem={feedbackItem} />
</Section>

{eventData ? (
<TraceDataSection
eventData={eventData}
crashReportId={crashReportId}
hasProject={!!feedbackItem.project}
/>
) : null}

{!crashReportId || (crashReportId && url) ? (
<Section icon={<IconLink size="xs" />} title={t('URL')}>
<TextCopyInput
Expand Down Expand Up @@ -122,6 +132,34 @@ export default function FeedbackItem({feedbackItem, eventData, tags}: Props) {
);
}

function TraceDataSection({

@michellewzhang michellewzhang Aug 26, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this to a new file? similar to how the other sections are structured

@aliu39 aliu39 Aug 29, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm I feel like it's small enough to keep here, it's basically a wrapper around Issue's TraceDataSection

eventData,
crashReportId,
hasProject,
}: {
crashReportId: string | undefined;
eventData: Event;
hasProject: boolean;
}) {
// If there's a linked error from a crash report and only one other issue, showing both could be redundant.
// TODO: we could add a jest test .spec for this ^
const {oneOtherIssueEvent, traceEvents, isLoading, isError} = useTraceTimelineEvents({
event: eventData,
});
const hide: boolean =
isLoading ||
isError ||
traceEvents.length <= 1 || // traceEvents include the current event.
(hasProject && !!crashReportId && oneOtherIssueEvent?.id === crashReportId);

// Note a timeline will only be shown for >1 same-trace issues.
return hide ? null : (
<Section>
<IssueDetailsTraceDataSection event={eventData} />
</Section>
);
}

// 0 padding-bottom because <ActivitySection> has space(2) built-in.
const OverflowPanelItem = styled(PanelItem)`
overflow: auto;
Expand Down