Repository navigation
Proposal: Retire make; Update build instructions for Cmake #133
Description
Now we have a shiny new cmake frontend, can we:
- eliminate the makefile?
- document the Cmake build instructions?
As far as I know, users might use the make file if they don't have cmake. There might also be some features in the makefile that still need to be transferred to cmakelist.txt.
But as far as I know, cmake will need to generate the makefile for each user's environment. So it may no longer make sense to track the makefile at all. Tracking the cmakelist.txt might be enough.
This of course puts the burden on the user to install cmake and know how to call it. That's a little more complicated that make. It would help to add the new steps to readme.md, and remove the old make-based build steps.
I can implement both, but ideas and suggestions are needed - what are the plans for supporting (or deprecating) the makefile / supporting make-based build steps? Lemme know we can get rid of em' all, and I can get to work! 🔥🔥🔥 Otherwise, lemme know the preferred approach!
Activity
lemmi commentedon Mar 14, 2023
At the moment, all I have to do is clone the repo and type
make. I'd love to see how you can beat that withcmake:)maxsu commentedon Mar 16, 2023
@lemmi I'm not saying cmake is easier to use. Cmake is definitely more annoying to use
But Cmake has snuck into the project thanks to PR #75. Whisper.cpp uses Cmake to support platforms like windows or android, and llamma.cpp could be moving in that direction.
Now we have both a MakeFile and Cmakelists.txt, and the second one has more features.
3 options:
Option 1 is easiest. Option 2 continues to support make users. Option 3 is best for make users, but could be a PITA to support.
Merge pull request ggml-org#133 from nikolaydubina/patch-1
release: windows-cuda arm64 as dll-only companion (ggml-cpu refuses M…
83 remaining items
rdna-boosts: block 05: flash-attention band, native quantized K/V and…
rdna-boosts: block 05: flash-attention band, native quantized K/V and…
rdna-boosts: block 05: flash-attention band, native quantized K/V and…
rdna-boosts: block 05: flash-attention band, native quantized K/V and…
rdna-boosts: block 05: flash-attention band, native quantized K/V and…
rdna-boosts: block 05: flash-attention band, native quantized K/V and…
rdna-boosts: block 05: flash-attention band, native quantized K/V and…
rdna-boosts: block 05: flash-attention band, native quantized K/V and…
rdna-boosts: block 05: flash-attention band, native quantized K/V and…
rdna-boosts: block 05: flash-attention band, native quantized K/V and…
rdna-boosts: block 05: flash-attention band, native quantized K/V and…
rdna-boosts: block 05: flash-attention band, native quantized K/V and…
rdna-boosts: block 05: flash-attention band, native quantized K/V and…
rdna-boosts: block 05: flash-attention band, native quantized K/V and…
rdna-boosts: block 05: flash-attention band, native quantized K/V and…