metal: convert shutdown assertion to warning log - #19206
Closed
arkavo-com wants to merge 1 commit into
Closed
arkavo-com wants to merge 1 commit into
arkavo-com wants to merge 1 commit into
Conversation
During process exit, Metal residency sets may not be fully cleaned up due to static destructor ordering. Log a warning instead of asserting, as the OS will reclaim resources anyway. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
Closing this PR as it was AI-generated, which violates the project's contributing guidelines. The fix will be resubmitted by a human contributor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During process exit, Metal residency sets may not be fully cleaned up due to static destructor ordering. This converts the fatal assertion in
ggml_metal_rsets_free()to a warning log, as the OS will reclaim GPU resources anyway.Problem
When embedding llama.cpp in applications that use
exit(), receive SIGINT, or don't perfectly clean up all contexts before shutdown, the assertion at line 608 fires:This happens because:
unique_ptringgml_metal_device_get())Dropimpls are skipped whenstd::process::exit()is called)Solution
Replace the assertion with a warning log. This:
Test