Skip to content

ggml-webgpu: Update register tiling matmul to use f32 accumulation - #21644

Merged
ggerganov merged 7 commits into
ggml-org:masterfrom
reeselevine:reg-tile-accum-fix
Apr 14, 2026
Merged

ggerganov merged 7 commits into
ggml-org:masterfrom
reeselevine:reg-tile-accum-fix

Conversation

@reeselevine

@reeselevine reeselevine commented Apr 8, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Requirements

@abhijitramesh

abhijitramesh commented Apr 9, 2026 •

Copy link
Copy Markdown
Contributor

The f32 accumulator fix seems to be helping us. I hooked this branch with wllama and ran the Qwen models; it seems to be working as expected on Firefox and Safari now. Chrome still seems to be broken, but it's no longer printing @@@.

Chrome output:
image

@github-actions github-actions Bot added ggml changes relating to the ggml tensor library for machine learning WebGPU labels Apr 9, 2026
@abhijitramesh

Copy link
Copy Markdown
Contributor
image Now it works on Chrome as well!

@reeselevine reeselevine added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Apr 13, 2026
@ggerganov
ggerganov merged commit 5a23695 into ggml-org:master Apr 14, 2026
46 of 47 checks passed
mengqin pushed a commit to mengqin/llama.cpp that referenced this pull request Apr 20, 2026
…gml-org#21644)

* Update register tiling matmul to use f32 accumulation

* fix profiling code

* Fix register tiling matmul for chrome, i'm blaming dawn

* Update batch tuning value for iOS

* compile fix

* Fix use of new load function
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
…gml-org#21644)

* Update register tiling matmul to use f32 accumulation

* fix profiling code

* Fix register tiling matmul for chrome, i'm blaming dawn

* Update batch tuning value for iOS

* compile fix

* Fix use of new load function
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
…gml-org#21644)

* Update register tiling matmul to use f32 accumulation

* fix profiling code

* Fix register tiling matmul for chrome, i'm blaming dawn

* Update batch tuning value for iOS

* compile fix

* Fix use of new load function
MrLordCat referenced this pull request in MrLordCat/llama.cpp-rdna-lab Jul 16, 2026
…21644)

* Update register tiling matmul to use f32 accumulation

* fix profiling code

* Fix register tiling matmul for chrome, i'm blaming dawn

* Update batch tuning value for iOS

* compile fix

* Fix use of new load function
zommiommy pushed a commit to zommiommy/llama.cpp that referenced this pull request Aug 18, 2026
…gml-org#21644)

* Update register tiling matmul to use f32 accumulation

* fix profiling code

* Fix register tiling matmul for chrome, i'm blaming dawn

* Update batch tuning value for iOS

* compile fix

* Fix use of new load function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. WebGPU

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants