Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix the location of pasted input within the user message.
ChatService.convertDbMessageToApiChatMessageDatapushedmessage.contentontocontentPartsbefore the attachment parts, so a "Pasted" text attachment was appended after the typed instruction.Additional information
Reordered the
contentPartsassembly so images, text/legacy/audio/PDF files and MCP prompts/resources are pushed first, withmessage.contentemitted last. This keeps the typed query trailing the pasted/uploaded data and keeps the attachment payload at a stable prefix position for cache reuse.Added
tools/server/webui/tests/unit/chat-service-attachment-order.test.tscovering the ordering.Fixes #22962
Requirements