Repository navigation
Conversation
Contributor
|
@0cc4m The looks neat and clean. Have one small follow-up on this. Pulling out vk_per_logger into its own ggml-vulkan-perf.cpp. Tried this in branch https://github.com/Raman-Raje/llama.cpp/tree/vulkan-cpp-split |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is the first step to split up the ggml-vulkan.cpp file into multiple files. I have a Python script that hopefully allows keeping this PR up to date without much work while waiting for a good moment to merge it. Some of the long-running draft PRs might have to be updated with the help of the script, I'm still looking into how best to enable that.
I also still have to go through the files and see what can/should be improved. Do add feedback if you have any. The script is here.
Requirements