Repository navigation
hexagon: add VISION RoPE support - #25216
Merged
Merged
Conversation
github-actions
Bot
added
ggml
| return false; | ||
| } | ||
| } | ||
|
|
||
| // src0 rows must be densely packed so each DMA transfer covers exactly one row |
Member
There was a problem hiding this comment.
I think this check is actually not correct. The dma setup we have in the ROPE is properly handling src0->nb[1] strides. In fact I believe we can remove all ggml_is_contiguous checks here but need to double check.
aparmp-quic
force-pushed
the
aparmp/hex-visionrope
branch
from
July 9, 2026 03:51
a79c3b3 to
7772e1f
Compare
max-krasnyansky
approved these changes
Jul 9, 2026
lhez
approved these changes
Jul 9, 2026
satindergrewal
pushed a commit
to satindergrewal/llama.cpp
that referenced
this pull request
Aug 12, 2026
* hexagon: add VISION RoPE support * hexagon: support RoPE on strided half-dim views for all modes * hex-rope: decouple src0 DMA copy size from row stride * hex-rope: support non-contiguous dst for RoPE * hex-rope: fix dst spad pitch for non-contiguous dst
zbrad
pushed a commit
to zbrad/llama.cpp
that referenced
this pull request
Sep 10, 2026
* hexagon: add VISION RoPE support * hexagon: support RoPE on strided half-dim views for all modes * hex-rope: decouple src0 DMA copy size from row stride * hex-rope: support non-contiguous dst for RoPE * hex-rope: fix dst spad pitch for non-contiguous dst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Support VISION RoPE and strided src0 for RoPE at hexagon. Enables RoPE ops from the Qwen2-VL / Qwen3-VL vision encoder (ViT).
Requirements