Repository navigation
ui: export conversations from database instead of cached store - #27432
Merged
ServeurpersoCom merged 1 commit intoSep 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Fixes Settings/Sidebar conversation export to always source conversations (including currNode) from IndexedDB rather than potentially-stale in-memory cache, preventing imports from showing all branches.
Changes:
- Centralized export data retrieval via
conversationsStore.getConversationsForExport()usingDatabaseService.getConversationsWithMessages. - Updated Settings export and single-conversation download to use the centralized DB-backed export source.
- Added unit/regression tests covering stale cache vs DB
currNodeand branch-pointer import behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tools/ui/src/lib/stores/conversations.svelte.ts | Introduces centralized DB-backed export fetch and routes export/download through it. |
| tools/ui/src/lib/components/app/settings/SettingsChat/SettingsChatImportExportTab.svelte | Switches Settings export to use the centralized DB-backed export source. |
| tools/ui/tests/unit/conversation-export-source.test.ts | Adds regression tests ensuring exports use DB currNode and imports restore the correct branch. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
intel00000
force-pushed
the
fix/webui-import-currnode
branch
from
August 27, 2026 05:41
b2b12f6 to
6fb5505
Compare
allozaur
approved these changes
Sep 4, 2026
x1250
pushed a commit
to x1250/llama.cpp
that referenced
this pull request
Sep 9, 2026
zbrad
pushed a commit
to zbrad/llama.cpp
that referenced
this pull request
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
bugfix on setting menu export/import
Additional information
When exporting a conversation with branches from the Settings (single or multi conversations), the output jsonl "currNode" field is empty. When this export is imported, all branches are displayed.
The cause: the settings export serialized the conversation header from
conversationsStore.conversations, which is a page-load cache and can hold a stale currNode. currNode advances in IndexedDB on message insert, but not all are updated into cache, so a conversation created in the current page session has empty currNode.To recreate it:
Shown below
Before export


Re-imported
Fix:
Requirements