Repository navigation
ggml-cpu(s390x): fix q5_1 uninitialized v_acc - #28332
Merged
Merged
Conversation
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Member
Author
|
cc: @AlekseiNikiforovIBM @Andreas-Krebbel for a quick check |
Contributor
|
LGTM |
9 of 10 tasks
1 task done
x1250
pushed a commit
to x1250/llama.cpp
that referenced
this pull request
Sep 9, 2026
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
zbrad
pushed a commit
to zbrad/llama.cpp
that referenced
this pull request
Sep 10, 2026
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
fixes #28281
I forgot to use
vec_splats(0.0f)when accumulating, and instead usedv_acc, which was undefined. Quoting @IgorTodorovskiIBM:Relatively simple fix, not sure how I overlooked it.
Requirements