openvino: serve GET_ROWS on a weight view from the base Constant - #28381
Merged
ServeurpersoCom merged 2 commits intoSep 30, 2026
Merged
ServeurpersoCom merged 2 commits into
ServeurpersoCom merged 2 commits into
Conversation
github-actions
Bot
added
ggml
wine99
approved these changes
Sep 7, 2026
wine99
left a comment
wine99
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thank you for fixing. cc @cavusmustafa @ravi9
ServeurpersoCom
force-pushed
the
openvino-get-rows-weight-view
branch
from
September 7, 2026 10:23
2d62eac to
9e2a46e
Compare
Contributor
Author
|
Rebase only |
ServeurpersoCom
force-pushed
the
openvino-get-rows-weight-view
branch
from
September 27, 2026 18:05
9e2a46e to
e5f02c5
Compare
Contributor
Author
|
Rebased on top of #28638 and #29009, neither touches the weight view path. Also lifts the supports_op rejection added in #28253 as a stopgap, so the vs0 cases now reach OpenVINO. Tested with OpenVINO 2026.4 on the CPU device:
|
Resolve view_src when collecting weight Constants so a view over a quantized weight no longer becomes a dynamic typed Parameter, and fold the row offset of the view into the gather indices instead of slicing the dequantization subgraph.
The supports_op rejection of a quantized src0 view with a nonzero offset keeps the vs0 GET_ROWS cases of ggml-org#28253 away from OpenVINO. The weight view now resolves to the base Constant with the row offset folded into the gather indices, so the rejection goes away.
ServeurpersoCom
force-pushed
the
openvino-get-rows-weight-view
branch
from
September 30, 2026 06:55
4d24e63 to
2279a2a
Compare
CISC
approved these changes
Sep 30, 2026
pierreguillot
pushed a commit
to Ircam-Partiels/llama.cpp
that referenced
this pull request
Oct 1, 2026
…l-org#28381) * openvino: serve GET_ROWS on a weight view from the base Constant Resolve view_src when collecting weight Constants so a view over a quantized weight no longer becomes a dynamic typed Parameter, and fold the row offset of the view into the gather indices instead of slicing the dequantization subgraph. * openvino: lift the quantized GET_ROWS view rejection The supports_op rejection of a quantized src0 view with a nonzero offset keeps the vs0 GET_ROWS cases of ggml-org#28253 away from OpenVINO. The weight view now resolves to the base Constant with the row offset folded into the gather indices, so the rejection goes away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This fixes the GET_ROWS failures that #28253 exposes on the OpenVINO runner, a view over a quantized weight was registered as a dynamic typed Parameter instead of being served by the base Constant, so the weight collection now resolves view_src and the row offset is folded into the gather indices, validated locally on the CPU device with the CI toolkit (50/50 GET_ROWS, 3919/3919 full suite).
Additional information
Resolve view_src when collecting weight Constants so a view over a quantized weight no longer becomes a dynamic typed Parameter, and fold the row offset of the view into the gather indices instead of slicing the dequantization subgraph.
Test
Tested on the CPU device with the CI 2026.3.1 toolkit, which reproduces the same 8 failures as the GPU runner, GET_ROWS goes from 42/50 to 50/50 and the full suite passes 3919/3919.
Requirements