Skip to content

Fix #28491 linking bug when compiling with BUILD_SHARED_LIBS=OFF #28492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggerganov merged 1 commit into from
Sep 12, 2026
Merged

Fix #28491 linking bug when compiling with BUILD_SHARED_LIBS=OFF #28492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ggml/src/ggml-rpc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,10 @@ if (GGML_RPC_RDMA)
target_compile_definitions(ggml-rpc PRIVATE GGML_RPC_RDMA)
if (APPLE)
# librdma.dylib only exists on macOS 26.2 and later. Link it weakly so a build made
# where it exists still loads where it does not; checked at runtime before use.
target_link_options(ggml-rpc PRIVATE "LINKER:-weak_library,${RDMA_LIB}")
# where it exists still loads where it does not; checked at runtime before use
# but with BUILD_SHARED_LIBS=OFF ggml-rpc is a static archive and never links
# so the librdma symbols used by transport-apple.cpp stay undefined.
target_link_options(ggml-rpc PUBLIC "LINKER:-weak_library,${RDMA_LIB}")
target_compile_definitions(ggml-rpc PRIVATE GGML_RPC_RDMA_APPLE)
target_sources(ggml-rpc PRIVATE transport-apple.cpp)
else()
Expand Down
Loading