Skip to content

hexagon: fix batch buffer bounds and strided copy dispatch - #28516

Closed
happyyzy wants to merge 1 commit into
ggml-org:masterfrom
happyyzy:fix/hexagon-buffer-bounds-strided-copy
Closed

happyyzy wants to merge 1 commit into
ggml-org:masterfrom
happyyzy:fix/hexagon-buffer-bounds-strided-copy

Conversation

@happyyzy

@happyyzy happyyzy commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

Overview

  • The batch buffer assertion runs after n_bufs++, so adding the valid 16th buffer aborts. Move the check before the increment, keeping HTP_OP_MAX_BUFS unchanged.
  • Equal shapes do not imply contiguous inner elements. The same-shape copy fast paths ignore dimension-0 strides and can copy incorrect values. Require element-size inner strides on both sides; same-type strided copies use the existing HTP strided path.

Requirements

@happyyzy
happyyzy requested a review from a team as a code owner September 6, 2026 20:46
@github-actions github-actions Bot added ggml changes relating to the ggml tensor library for machine learning Hexagon labels Sep 6, 2026
@happyyzy

happyyzy commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

@lhez @max-krasnyansky, could you take a look at the changes when you have a chance?

@max-krasnyansky

Copy link
Copy Markdown
Member

@happyyzy
I actually ran into those myself while working on #28589
Codex with Terra found a bunch of little things like that :).
So it should be fixed in that big PR and we should be able to merge that soon (going through more reviews and validation).

@happyyzy happyyzy closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning Hexagon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants