Skip to content

metal: fix metal tensor kernel_mul_mm error for large tensor #28748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggerganov merged 2 commits into from
Oct 12, 2026
Merged

metal: fix metal tensor kernel_mul_mm error for large tensor #28748

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d730a3c
metal: fix metal tensor kernel_mul_mm error for large tensor
Sep 10, 2026
f80bd9f
Update ggml/src/ggml-metal/kernels/mul_mm.metal
SecondSeed Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions ggml/src/ggml-metal/kernels/mul_mm.metal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,15 @@ kernel void kernel_mul_mm(
}

// Store result tile to output matrix (with batch offset)
// cT.store handles bounds checking via tD's extents (M, N)
device float * dstBatch = (device float *)dst + im * N * M;
// a slice is not used because its byte offset is int32 and wraps at 2 GiB
// ref: https://github.com/ggml-org/llama.cpp/pull/28748
const int tileM = min(NRA, M - ra);
Comment thread
SecondSeed marked this conversation as resolved.
const int tileN = min(NRB, N - rb);

auto tD = tensor(dstBatch, dextents<int32_t, 2>(M, N), array<int, 2>({1, M}));
cT.store(tD.slice(ra, rb));
device float * dstTile = (device float *)dst + (uint64_t) im * N * M + (uint64_t) rb * M + ra;

auto tD = tensor(dstTile, dextents<int32_t, 2>(tileM, tileN), array<int, 2>({1, M}));
cT.store(tD);
}

#else
Expand Down