cmake : skip PCH for llama-server PCH when using MSVC - #28763
Merged
Merged
Conversation
This commit fixes an issue that I introduced when adding PCH (precompiled headers) in Commit 3bcfeb7 ("cmake : add PCH and unity build to improve build times (ggml-org#28091)". See linked issue for details. Co-authored-by: mjungnickel18 Co-authored-by: Pascal <admin@serveurperso.com> Resolves: ggml-org#28758 Refs: https://github.com/ggml-org/llama.cpp/actions/runs/34592933983/job/103262608990#step:9:1284
ServeurpersoCom
approved these changes
Sep 11, 2026
ServeurpersoCom
left a comment
ServeurpersoCom
left a comment
Contributor
There was a problem hiding this comment.
If the CI goes through, we'll be all good:)
ggerganov
approved these changes
Sep 11, 2026
Contributor
|
I need this before #28555 |
Member
|
I think |
Contributor
|
pl752
pushed a commit
to pl752/llama.cpp
that referenced
this pull request
Sep 15, 2026
This commit fixes an issue that I introduced when adding PCH (precompiled headers) in Commit 3bcfeb7 ("cmake : add PCH and unity build to improve build times (ggml-org#28091)". See linked issue for details. Co-authored-by: mjungnickel18 Co-authored-by: Pascal <admin@serveurperso.com> Resolves: ggml-org#28758 Refs: https://github.com/ggml-org/llama.cpp/actions/runs/34592933983/job/103262608990#step:9:1284
quimmedes
pushed a commit
to quimmedes/cafe-llama.cpp
that referenced
this pull request
Sep 16, 2026
This commit fixes an issue that I introduced when adding PCH (precompiled headers) in Commit 3bcfeb7 ("cmake : add PCH and unity build to improve build times (ggml-org#28091)". See linked issue for details. Co-authored-by: mjungnickel18 Co-authored-by: Pascal <admin@serveurperso.com> Resolves: ggml-org#28758 Refs: https://github.com/ggml-org/llama.cpp/actions/runs/34592933983/job/103262608990#step:9:1284
zsogitbe
pushed a commit
to zsogitbe/llama.cpp
that referenced
this pull request
Sep 17, 2026
This commit fixes an issue that I introduced when adding PCH (precompiled headers) in Commit 3bcfeb7 ("cmake : add PCH and unity build to improve build times (ggml-org#28091)". See linked issue for details. Co-authored-by: mjungnickel18 Co-authored-by: Pascal <admin@serveurperso.com> Resolves: ggml-org#28758 Refs: https://github.com/ggml-org/llama.cpp/actions/runs/34592933983/job/103262608990#step:9:1284
Te-eMster
pushed a commit
to Te-eMster/mx-llama.cpp
that referenced
this pull request
Sep 18, 2026
This commit fixes an issue that I introduced when adding PCH (precompiled headers) in Commit 3bcfeb7 ("cmake : add PCH and unity build to improve build times (ggml-org#28091)". See linked issue for details. Co-authored-by: mjungnickel18 Co-authored-by: Pascal <admin@serveurperso.com> Resolves: ggml-org#28758 Refs: https://github.com/ggml-org/llama.cpp/actions/runs/34592933983/job/103262608990#step:9:1284
Te-eMster
pushed a commit
to Te-eMster/mx-llama.cpp
that referenced
this pull request
Sep 18, 2026
This commit fixes an issue that I introduced when adding PCH (precompiled headers) in Commit 3bcfeb7 ("cmake : add PCH and unity build to improve build times (ggml-org#28091)". See linked issue for details. Co-authored-by: mjungnickel18 Co-authored-by: Pascal <admin@serveurperso.com> Resolves: ggml-org#28758 Refs: https://github.com/ggml-org/llama.cpp/actions/runs/34592933983/job/103262608990#step:9:1284
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This commit fixes an issue that I introduced when adding PCH (precompiled headers) in Commit 3bcfeb7 ("cmake : add PCH and unity build to improve build times (#28091)".
Additional information
See linked issue for details.
Resolves: #28758
Refs: https://github.com/ggml-org/llama.cpp/actions/runs/34592933983/job/103262608990#step:9:1284
Requirements
Co-authored-by: mjungnickel18
Co-authored-by: Pascal admin@serveurperso.com