Repository navigation
[SYCL] Fix function signature for ggml_backend_sycl_split_buffer_type - #28981
Merged
Merged
Conversation
also add C++17 attribute [[maybe_unused]] to function `ggml_sycl_set_peer_access`. This adds no new functionality, but may *partially* address some errors relating to multi-GPU setups using SYCL. pi / Qwen was used leading to the discovery of this issue, it was not used in writing of the code, issues, or this commit message. Assisted-by: pi (unsloth/Qwen3.8-27B-GGUF:Q4_K_M via llama.cpp)
github-actions
Bot
added
ggml
arthw
approved these changes
Sep 16, 2026
arthw
left a comment
arthw
left a comment
Contributor
There was a problem hiding this comment.
It's good job!
The multiple GPUs is blocked by other issue.
The issue fixed by this PR is screened by them.
I will fix it as soon.
Thank you!
arthw
added
the
merge ready
Titaniumtown
approved these changes
Sep 17, 2026
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Corrects the function signature for the function
ggml_backend_sycl_split_buffer_typeof the SYCL implementation ofggml_backend_split_buffer_type_tfunction.Also add C++17 attribute
[[maybe_unused]]to functionggml_sycl_set_peer_access.This adds no new functionality, but may partially address some errors relating to multi-GPU setups using SYCL.
Additional information
Issue #28980 - Misc. bug: [SYCL] incorrect func sig for ggml_backend_sycl_split_buffer_type
Requirements
Pi / Qwen was used leading to the discovery of this issue, it was not used in writing of the code, issue, commit message, or this PR.
Assisted-by: pi (unsloth/Qwen3.8-27B-GGUF:Q4_K_M via llama.cpp)