Skip to content

sycl: remove duplicate block-size defines from op headers #29507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggerganov merged 1 commit into from
Oct 8, 2026
Merged

sycl: remove duplicate block-size defines from op headers #29507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ggml/src/ggml-sycl/im2col.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@

#include "common.hpp"

#define SYCL_IM2COL_BLOCK_SIZE 256

void ggml_sycl_op_im2col(ggml_backend_sycl_context & ctx, ggml_tensor * dst);
void ggml_sycl_op_im2col_3d(ggml_backend_sycl_context & ctx, ggml_tensor * dst);

Expand Down
2 changes: 0 additions & 2 deletions ggml/src/ggml-sycl/pad.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@

#include "common.hpp"

#define SYCL_PAD_BLOCK_SIZE 256

void ggml_sycl_pad(ggml_backend_sycl_context & ctx, ggml_tensor * dst);

void ggml_sycl_op_pad(ggml_backend_sycl_context & ctx, ggml_tensor * dst);
Expand Down
2 changes: 0 additions & 2 deletions ggml/src/ggml-sycl/rope.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@

#include "common.hpp"

#define SYCL_ROPE_BLOCK_SIZE 256

void ggml_sycl_rope(ggml_backend_sycl_context & ctx, ggml_tensor *dst);

void ggml_sycl_rope_back(ggml_backend_sycl_context & ctx, ggml_tensor * dst);
Expand Down
2 changes: 0 additions & 2 deletions ggml/src/ggml-sycl/upscale.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,4 @@
#include "dpct/helper.hpp"
#include "common.hpp"

#define SYCL_UPSCALE_BLOCK_SIZE 256

void ggml_sycl_upscale(ggml_backend_sycl_context & ctx, ggml_tensor * dst);