Skip to content

context : simplify setters #29730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikwen wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −12
Open

context : simplify setters #29730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/llama-context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1379,14 +1379,9 @@ void llama_context::set_nextn_layer_offset(int32_t offset) {
void llama_context::set_causal_attn(bool value) {
LLAMA_LOG_DEBUG("%s: value = %d\n", __func__, value);

if (cparams.causal_attn == value) {
return;
}
// no scheduler reserve needed because graph shapes must not depend on causal_attn, a flip only rebuilds the graph

cparams.causal_attn = value;

// no scheduler reserve needed because graph shapes must not depend on causal_attn, a flip only rebuilds the graph
//sched_need_reserve = true;
}

bool llama_context::get_causal_attn() const {
Expand All @@ -1396,14 +1391,9 @@ bool llama_context::get_causal_attn() const {
void llama_context::set_warmup(bool value) {
LLAMA_LOG_DEBUG("%s: value = %d\n", __func__, value);

if (cparams.warmup == value) {
return;
}
// no scheduler reserve needed because warmups are usually with small batches

cparams.warmup = value;

// warmups are usually with small batches, so no need to reserve
//sched_need_reserve = true;
}

bool llama_context::set_sampler(llama_seq_id seq_id, llama_sampler * sampler) {
Expand Down