Repository navigation
Conversation
joelagnel
force-pushed
the
pr/cuda-graph-warmup
branch
from
October 1, 2026 22:48
3cbbc04 to
bd154f9
Compare
joelagnel
marked this pull request as draft
October 7, 2026 22:50
joelagnel
force-pushed
the
pr/cuda-graph-warmup
branch
from
October 7, 2026 22:50
bd154f9 to
c604639
Compare
Contributor
|
This PR is going to be incompatible with #22155 that can cause If you capture graph in such a case, it will break. |
joelagnel
force-pushed
the
pr/cuda-graph-warmup
branch
from
October 8, 2026 15:08
c604639 to
6f69429
Compare
Contributor
Author
|
@gaugarg-nv, thanks a lot, I agree there is a chance of |
joelagnel
force-pushed
the
pr/cuda-graph-warmup
branch
from
October 12, 2026 14:48
6f69429 to
ae89254
Compare
joelagnel
marked this pull request as ready for review
October 12, 2026 14:49
joelagnel
force-pushed
the
pr/cuda-graph-warmup
branch
from
October 12, 2026 14:52
ae89254 to
f69225e
Compare
Recapture a changed graph at once after it has replayed unchanged, if no node changes op or starts or stops running a kernel. Keep the initial warmup, and reset it when graph properties keep changing or a node changes. Benchmark results on RTX 5090: llama-batched-bench -c 131072 -b 2048 -ub 512 -npp 15872 -ntg 512 -npl 8 -ngl 99 -t 4 -tb 4 -fa on -ctk f16 -ctv f16 -kvu -lv 5 Configuration: - RTX 5090, Windows x64, driver 617.14, CUDA 12.9. - Qwen3.8-27B Q4_K_M. +------------------------+------------+-------------------------+------------------+------------------+ | Workload | Mean effect| 95% CI | With patch | Without patch | +------------------------+------------+-------------------------+------------------+------------------+ | llama-batched-bench | +1.14% | +0.44% to +1.84% | 299.21 tok/s mean| 295.85 tok/s mean| | | | | 299.82 median | 295.80 median | +------------------------+------------+-------------------------+------------------+------------------+ I also tested thoroughly on RTXspark (NVIDIA N1X) and DGX Spark (GB10) and for those, no statistically significant improvement or regression was detected. Assisted-by: Codex Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
joelagnel
force-pushed
the
pr/cuda-graph-warmup
branch
from
October 13, 2026 21:54
f69225e to
d29d234
Compare
Contributor
|
@joelagnel Can you test dflash2 and MTP (chose draft length of 7 and 15 for both) with some In these cases, I would expect |
6 tasks
joelagnel
marked this pull request as draft
October 23, 2026 10:52
francisab
added a commit
to francisab/llama.cpp
that referenced
this pull request
Oct 24, 2026
Assisted-by: GitHub Copilot Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
francisab
added a commit
to francisab/llama.cpp
that referenced
this pull request
Oct 24, 2026
Assisted-by: GitHub Copilot Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recapture a changed graph at once after it has replayed unchanged, if no
node changes op or starts or stops running a kernel. Keep the initial
warmup, and reset it when graph properties keep changing or a node
changes.
Benchmark results on RTX 5090:
I also tested thoroughly on RTXspark (NVIDIA N1X) and DGX Spark (GB10)
and for those, no statistically significant improvement or regression
was detected.