Repository navigation
convert : add text_config as fallback [transformers 5.18] - #30040
Merged
Merged
Conversation
CISC
approved these changes
Oct 6, 2026
CISC
left a comment
CISC
left a comment
Member
There was a problem hiding this comment.
This is actually a hold-over, load_hparams consolidates all variants into text_config.
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@huggingface.co>
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 24, 2026
…0040) * add text_config as fallback * remove redundant llm_config check Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@huggingface.co> --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@huggingface.co>
auRose94
pushed a commit
to auRose94/llama.cpp
that referenced
this pull request
Oct 28, 2026
…0040) * add text_config as fallback * remove redundant llm_config check Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@huggingface.co> --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@huggingface.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Transformers 5.18 maps
llm_configtotext_config, which consumes the original field. Hence, the fields that are expected to be found underllm_configare absent and we run into the following error -This PR resolves that by adding
text_configas a fallback ifllm_configis not found. This should not disturb any current working and add 5.18 compatibility.Requirements